Re: pgsql: Remove useless whitespace at end of lines

From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, pgsql-committers <pgsql-committers(at)postgresql(dot)org>
Subject: Re: pgsql: Remove useless whitespace at end of lines
Date: 2010-11-25 12:55:02
Message-ID: 1290689533-sup-5489@alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Excerpts from Magnus Hagander's message of jue nov 25 05:46:49 -0300 2010:
> On Wed, Nov 24, 2010 at 23:54, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:

> > Its not so much the moderation load, as I don't like being blindsided by
> > commits that touch everything in sight.  Finding out only when you try
> > to do git push (as indeed happened to me just this afternoon because of
> > this patch) is annoying.
>
> fair enough. I'm not sure the size limit actually protects us against
> anything, so I'm not against increasing it.

So, given that this commit touched 517 files and resulted in a 47341b
message, the minimum size we should use is about 332kB for the 3633
files present in the source tree (I counted all the files, not just the
ones with copyright lines, out of pure laziness).

I've set the limit to 400 kB to have a wide safety margin. Large commits
should now pass through unmoderated.

--
Álvaro Herrera <alvherre(at)commandprompt(dot)com>
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Robert Haas 2010-11-25 16:52:08 pgsql: Object access hook framework, with post-creation hook.
Previous Message User Itagaki 2010-11-25 12:37:56 textsearch-ja - textsearch_groonga: Use PGXS automatically on make.

Browse pgsql-hackers by date

  From Date Subject
Next Message Heikki Linnakangas 2010-11-25 13:03:29 Re: SQL/MED - core functionality
Previous Message Radosław Smogura 2010-11-25 12:03:23 Re: [JDBC] JDBC and Binary protocol error, for some statements