From: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
---|---|
To: | Dimitri Fontaine <dimitri(at)2ndquadrant(dot)fr> |
Cc: | Itagaki Takahiro <itagaki(dot)takahiro(at)gmail(dot)com>, David Fetter <david(at)fetter(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Extensions, this time with a patch |
Date: | 2010-11-22 22:19:40 |
Message-ID: | 1290464046-sup-6478@alvh.no-ip.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Excerpts from Dimitri Fontaine's message of lun nov 22 18:12:39 -0300 2010:
> Itagaki Takahiro <itagaki(dot)takahiro(at)gmail(dot)com> writes:
> > No. My suggestion was just to use the internal parser.
>
> What about something like the attached, cfparser.v3.patch?
the handling of relative vs absolute paths is bogus here. I think it'd
make more sense to have a bool "are we including"; and if that's false and
the path is not absolute, then the file is relative to CWD; or maybe we
make it absolute by prepending PGDATA; maybe something else? (need to
think of something that makes sense for both recovery.conf and extension
control files)
> If that looks ok, do we want to add some documentation about the new
> lexer capabilities?
beyond extra code comments? probably not.
> Also, for what good reason would we want to prevent
> people from using the include facility?
Not sure about this
--
Álvaro Herrera <alvherre(at)commandprompt(dot)com>
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support
From | Date | Subject | |
---|---|---|---|
Next Message | Alvaro Herrera | 2010-11-22 22:55:37 | reporting reason for certain locks |
Previous Message | Alvaro Herrera | 2010-11-22 22:02:31 | Re: Extensions, this time with a patch |