From: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: describe objects, as in pg_depend |
Date: | 2010-11-18 17:23:21 |
Message-ID: | 1290100722-sup-6099@alvh.no-ip.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Thanks for the comments. Updated patch attached.
In the process of looking it over again, I noticed that in an
assert-enabled build, it's trivial to crash the server with this
function: just pass a nonzero subobjid with an object class that doesn't
take one. This could be fixed easily by turning the Asserts into
elog(ERROR).
Another problem with this function is that a lot of checks that
currently raise errors with elog(ERROR) are now user-facing. On this
issue one possible answer would be to do nothing; another would be to go
over all those calls and turn them into full-fledged ereports.
--
Álvaro Herrera <alvherre(at)commandprompt(dot)com>
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support
Attachment | Content-Type | Size |
---|---|---|
0001-Add-pg_describe_object-function.patch | application/octet-stream | 4.8 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2010-11-18 17:26:33 | Re: EXPLAIN and nfiltered |
Previous Message | Tom Lane | 2010-11-18 17:19:25 | Re: final patch - plpgsql: for-in-array |