| From: | Jeff Davis <pgsql(at)j-davis(dot)com> |
|---|---|
| To: | Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> |
| Cc: | pgsql-bugs(at)postgresql(dot)org |
| Subject: | Re: Recovery bug |
| Date: | 2010-11-11 17:10:14 |
| Message-ID: | 1289495414.18031.1.camel@jdavis |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On Thu, 2010-11-11 at 18:20 +0200, Heikki Linnakangas wrote:
> On 11.11.2010 02:20, Jeff Davis wrote:
> > There is a problem with this patch. ReadRecord() not only modifies
> > global variables, it also modifies the location pointed to by "record",
> > which is later used to set "wasShutdown". How about if we only set
> > "wasShutdown" if there is no backup_label (because the checkpoint for
> > pg_start_backup() will never be a shutdown checkpoint anyway)?
>
> Oh, good catch.
>
> > Trivial patch attached.
>
> Hmm, you're assuming that the checkpoint specified in the backup label
> is never a shutdown checkpoint. I guess that's true, but I'd rather do
> this (patch attached).
>
Looks good to me. Thanks!
> (StartupXLOG is quite a mess...)
Agreed.
Regards,
Jeff Davis
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Yeb Havinga | 2010-11-11 20:13:43 | Re: BUG #5748: Invalid oidvector data during binary recv |
| Previous Message | Tom Lane | 2010-11-11 16:56:58 | Re: BUG #5748: Invalid oidvector data during binary recv |