| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
| Cc: | tanghy(dot)fnst(at)fujitsu(dot)com, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: use pg_strncasecmp to replace strncmp when compare "pg_" |
| Date: | 2021-04-23 05:06:21 |
| Message-ID: | 1286655.1619154381@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> writes:
> At Thu, 22 Apr 2021 12:44:28 +0000, "tanghy(dot)fnst(at)fujitsu(dot)com" <tanghy(dot)fnst(at)fujitsu(dot)com> wrote in
>> When try to improve the tab compleation feature in [1], I found an existing problem and a typo.
>> The patch was attached, please kindly to take a look at it. Thanks.
> That doesn't matter at all for now since we match schema identifiers
> case-sensitively. Maybe it should be a part of the patch in [1].
Yeah --- maybe this'd make sense as part of a full patch to improve
tab-complete.c's handling of case folding, but I'm suspicious that
applying it on its own would just make things less consistent.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kyotaro Horiguchi | 2021-04-23 05:11:36 | Re: INT64_FORMAT in translatable strings |
| Previous Message | Tom Lane | 2021-04-23 05:03:41 | Re: Forgot some LSN_FORMAT_ARGS() in xlogreader.c |