| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Christoph Berg <myon(at)debian(dot)org> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org, Álvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Sami Imseih <samimseih(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Julien Rouhaud <rjuju123(at)gmail(dot)com> |
| Subject: | Re: Squash constant lists in query jumbling by default |
| Date: | 2025-03-25 16:53:13 |
| Message-ID: | 1282250.1742921593@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Christoph Berg <myon(at)debian(dot)org> writes:
> For 2), Tom said that configurability is 1) often much less useful
> than originally planned, and 2) tools have to cope with both settings
> anyway, making implementing them harder. Plus, switching at run-time
> makes the result even less predictable.
To clarify that last bit: if some clients run with the GUC on and some
with it off, you have a mess. Even statements that are completely
identical will have different query IDs under the two settings.
If this GUC sticks around, it should be at least PGC_SUSET (on
the analogy of compute_query_id) to make it harder to break
pg_stat_statements that way.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Daniel Gustafsson | 2025-03-25 16:58:15 | pgsql: psql: Make default \watch interval configurable |
| Previous Message | Daniel Gustafsson | 2025-03-25 16:29:26 | pgsql: pg_basebackup: Add missing PQclear in error path |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Sami Imseih | 2025-03-25 16:58:21 | Re: query_id: jumble names of temp tables for better pg_stat_statement UX |
| Previous Message | Peter Eisentraut | 2025-03-25 16:48:46 | Re: NOT ENFORCED constraint feature |