From: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
---|---|
To: | Joseph Adams <joeyadams3(dot)14159(at)gmail(dot)com> |
Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: patch: Add JSON datatype to PostgreSQL (GSoC, WIP) |
Date: | 2010-08-10 15:32:23 |
Message-ID: | 1281454126-sup-3094@alvh.no-ip.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Excerpts from Joseph Adams's message of mar ago 10 04:03:43 -0400 2010:
> An overview, along with my thoughts, of the utility functions:
>
> FN_EXTRA, FN_EXTRA_ALLOC, FN_MCXT macros
> * Useful-ometer: ()--------------------o
>
> TypeInfo structure and getTypeInfo function
> * Useful-ometer: ()---------------------------o
>
> getEnumLabelOids
> * Useful-ometer: ()-----------------------------------o
I think this kind of thing could be stripped from the patch and
submitted separately; they would presumably see a quick review and
commit if they are small and useful (particularly if you can show a
decrease of code verbosity by switching other uses in the existing
code).
The advantage is you don't have to keep arguing for their usefulness in
the JSON patch; and if they turn out to be rejected, they won't cause
the JSON patch to be rejected as a whole.
--
Álvaro Herrera <alvherre(at)commandprompt(dot)com>
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support
From | Date | Subject | |
---|---|---|---|
Next Message | Stephen Frost | 2010-08-10 15:39:37 | Re: host name support in pg_hba.conf |
Previous Message | Thom Brown | 2010-08-10 15:32:22 | Re: Session timeout on commitfest.postgresql.org |