Re: need more ALTER TABLE guards for typed tables

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: need more ALTER TABLE guards for typed tables
Date: 2010-07-22 19:34:07
Message-ID: 1279827247.16475.0.camel@vanquo.pezone.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On ons, 2010-07-21 at 15:48 -0400, Alvaro Herrera wrote:
> Excerpts from Peter Eisentraut's message of mié jul 21 15:18:58 -0400 2010:
> > After some investigation I figured that I need to add two more checks
> > into the ALTER TABLE code to prevent certain types of direct changes to
> > typed tables (see attached patch).
> >
> > But it's not clear to me whether such checks should go into the "Prep"
> > or the "Exec" phases. Prep seems more plausible to me, but some
> > commands such as DropColumn don't have a Prep handler. A clarification
> > would be helpful.
>
> I think if there's no Prep phase, you should add it. I don't think it
> makes sense to have this kind of check in Exec.

OK, here is my patch for this. (should go into 9.0 and 9.1)

Attachment Content-Type Size
dont-alter-typed-tables.patch text/x-patch 7.3 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Kris Jurka 2010-07-22 19:49:39 Re: Trouble with COPY IN
Previous Message Kevin Grittner 2010-07-22 19:26:37 Re: CommitFest 2010-07 week one progress report