Re: [HACKERS] I can't compile cvs snapshot ...

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <maillist(at)candle(dot)pha(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgreSQL(dot)org
Subject: Re: [HACKERS] I can't compile cvs snapshot ...
Date: 1999-05-26 13:55:48
Message-ID: 12764.927726948@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Bruce Momjian <maillist(at)candle(dot)pha(dot)pa(dot)us> writes:
>> Does this mean we are not allowed to use "U"? I think this is leagal
>> according to the standard C grammer.

> Well, it seems BSD indent mucks up 0x7fU, so I would prefer if we didn't
> use it.

If pgindent mucks up standard C constructs then pgindent is broken.

This is not open to debate --- if you are going to run our entire
source base through pgindent just a few days before every release,
then the tool has to be something we can have 100 percent, no-questions-
asked confidence in. Telling people to obey weird little coding
conventions is no answer. (If everyone reliably did that, we'd not
need pgindent in the first place.)

It appears that BSD indent doesn't have a problem with 0xnnnL, so
teaching it about 0xnnnU can't be that hard if you have the source.
(I don't...)

Maybe it is time to take another look at GNU indent?

regards, tom lane

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 1999-05-26 14:00:21 Re: [HACKERS] I can't compile cvs snapshot ...
Previous Message Jan Wieck 1999-05-26 13:48:52 Re: [HACKERS] Help: fmgr_info: function 0: cache lookup failed