Re: pgsql: Add missing optimizer hooks for function cost and number of rows.

From: Simon Riggs <simon(at)2ndQuadrant(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-committers(at)postgresql(dot)org, pgsql-hackers(at)postgresql(dot)org
Subject: Re: pgsql: Add missing optimizer hooks for function cost and number of rows.
Date: 2010-04-24 07:31:16
Message-ID: 1272094276.4161.960.camel@ebony
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Fri, 2010-04-23 at 18:55 -0400, Tom Lane wrote:
> sriggs(at)postgresql(dot)org (Simon Riggs) writes:
> > Log Message:
> > -----------
> > Add missing optimizer hooks for function cost and number of rows.
> > Closely follow design of other optimizer hooks: if hook exists
> > retrieve value from plugin; if still not set then get from cache.
>
> What exactly are we doing adding new features without discussion (or
> documentation, or known use cases) at this stage of the release cycle?

Existing hooks were not fully complete in their coverage. That has
happened before, and we have discussed that before on hackers, so I took
care not to deviate from that implementation. This is a very low impact
change, isn't in a new area and similar optimizer related changes were
made recently, so I saw little to object to in this particular change.
No such hooks are documented, even ones with strong use cases.

--
Simon Riggs www.2ndQuadrant.com

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Robert Haas 2010-04-24 11:10:13 Re: [HACKERS] Re: pgsql: Add missing optimizer hooks for function cost and number of rows.
Previous Message Robert Haas 2010-04-23 23:21:44 pgsql: Fix various instances of "the the".

Browse pgsql-hackers by date

  From Date Subject
Next Message Xiong He 2010-04-24 08:35:10 Re: Re: [HACKERS] vcregress.bat check triggered Heap error in the Debugversionof win32 build
Previous Message Pavel Stehule 2010-04-24 06:42:42 Re: global temporary tables