From: | Simon Riggs <simon(at)2ndQuadrant(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: Re: [COMMITTERS] pgsql: Tune GetSnapshotData() during Hot Standby by avoiding loop |
Date: | 2010-04-19 14:31:29 |
Message-ID: | 1271687489.8305.18879.camel@ebony |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
On Mon, 2010-04-19 at 10:24 -0400, Tom Lane wrote:
> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> > On Mon, Apr 19, 2010 at 5:05 AM, Simon Riggs <simon(at)2ndquadrant(dot)com> wrote:
> >> It doesn't seem to be something we should place highly on the list of
> >> events we need protection from, does it?
>
> > Since when do we not protect against race-conditions just because
> > they're low likelihood?
>
> Murphy's law says that the probability of any race condition happening
> in the field is orders of magnitude higher than you think. This has
> been proven true many times ...
Choices are
1. Check RecoveryInProgress() once outside of lock, plus wild rumour of
Murphy
2. Check RecoveryInProgress() before and after holding lock
3. Check RecoveryInProgress() while holding lock
All of which perform better than
4. Revert patch
--
Simon Riggs www.2ndQuadrant.com
From | Date | Subject | |
---|---|---|---|
Next Message | Heikki Linnakangas | 2010-04-19 14:44:07 | Re: Re: [COMMITTERS] pgsql: Tune GetSnapshotData() during Hot Standby by avoiding loop |
Previous Message | Tom Lane | 2010-04-19 14:24:28 | Re: Re: [COMMITTERS] pgsql: Tune GetSnapshotData() during Hot Standby by avoiding loop |
From | Date | Subject | |
---|---|---|---|
Next Message | Heikki Linnakangas | 2010-04-19 14:44:07 | Re: Re: [COMMITTERS] pgsql: Tune GetSnapshotData() during Hot Standby by avoiding loop |
Previous Message | Robert Haas | 2010-04-19 14:26:26 | Re: shared_buffers documentation |