Re: [COMMITTERS] pgsql: Check compulsory parameters in recovery.conf in standby_mode, per

From: Simon Riggs <simon(at)2ndQuadrant(dot)com>
To: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [COMMITTERS] pgsql: Check compulsory parameters in recovery.conf in standby_mode, per
Date: 2010-04-05 18:46:37
Message-ID: 1270493197.24910.4695.camel@ebony
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Mon, 2010-04-05 at 17:08 +0900, Fujii Masao wrote:
> On Sat, Apr 3, 2010 at 6:50 AM, Simon Riggs <sriggs(at)postgresql(dot)org> wrote:
> > Log Message:
> > -----------
> > Check compulsory parameters in recovery.conf in standby_mode, per docs.
>
> On the recent discussion (*1), some people argued that specifying neither
> primary_conninfo nor restore_command in the standby mode is not unreasonable,
> and we reached the consensus that the setting should be allowed. So this
> commit doesn't reflect the discussion. How about reverting the commit,
> and restarting the discussion if you have complaint against the consensus?

The attached patch changes the messages and downgrades FATAL to WARNING.

Comments?

--
Simon Riggs www.2ndQuadrant.com

Attachment Content-Type Size
msg_change.patch text/x-patch 966 bytes

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Simon Riggs 2010-04-05 18:48:55 Re: Re: [COMMITTERS] pgsql: Check compulsory parameters in recovery.conf in standby_mode, per
Previous Message Simon Riggs 2010-04-05 18:29:46 Re: Re: [COMMITTERS] pgsql: Check compulsory parameters in recovery.conf in standby_mode, per

Browse pgsql-hackers by date

  From Date Subject
Next Message Simon Riggs 2010-04-05 18:48:55 Re: Re: [COMMITTERS] pgsql: Check compulsory parameters in recovery.conf in standby_mode, per
Previous Message Simon Riggs 2010-04-05 18:45:10 Re: Parameter name standby_mode