| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
| Cc: | Zhihong Yu <zyu(at)yugabyte(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Peter Eisentraut <peter_e(at)gmx(dot)net>, Petr Jelinek <petr(at)2ndquadrant(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
| Subject: | Re: logical replication worker accesses catalogs in error context callback |
| Date: | 2021-07-03 16:33:03 |
| Message-ID: | 1270365.1625329983@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> writes:
> The patch basically looks good to me except a minor comment to have a
> local variable for var->varattno which makes the code shorter.
Here's a restructured version that uses rangetable data for the
simple-relation case too. I also modified the relevant test cases
so that it's visible that we're reporting aliases not true names.
regards, tom lane
| Attachment | Content-Type | Size |
|---|---|---|
| v8-0002-Avoid-Catalogue-Accesses-In-conversion_error_call.patch | text/x-diff | 7.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | John Naylor | 2021-07-03 17:06:59 | Re: cutting down the TODO list thread |
| Previous Message | Tom Lane | 2021-07-03 16:31:02 | Re: logical replication worker accesses catalogs in error context callback |