Re: Postmaster holding unlinked files for pg_largeobject table

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Kevin Grittner <kevin(dot)grittner(at)wicourts(dot)gov>, alexk <alexk(at)commandprompt(dot)com>, Alexander Shulgin <ash(at)commandprompt(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Postmaster holding unlinked files for pg_largeobject table
Date: 2011-06-09 19:02:33
Message-ID: 12703.1307646153@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-general pgsql-hackers

Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> On Thu, Jun 9, 2011 at 2:45 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> My thought is that it needs some beta testing. Perhaps it'd be sane to
>> push it into beta2 now, and then back-patch sometime after 9.1 final,
>> if no problems pop up.

> I think it'd be sensible to back-patch it. I'm not sure whether now
> or later. It's a bug fix that is biting real users in the field, so
> it seems like we ought to do something about it.

I don't deny it's a bug fix; I'm just dubious about the risk-reward
ratio. As to risk: the patch isn't trivial (notice Alvaro didn't get it
right the first time). As to reward: it's been like that since forever,
so if the problem were really serious, we'd have identified it before.

Letting it age a bit during beta would do a lot to damp down the risk
side of the equation.

regards, tom lane

In response to

Responses

Browse pgsql-general by date

  From Date Subject
Next Message Robert Haas 2011-06-09 19:03:26 Re: Postmaster holding unlinked files for pg_largeobject table
Previous Message Robert Haas 2011-06-09 18:49:23 Re: Postmaster holding unlinked files for pg_largeobject table

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2011-06-09 19:03:26 Re: Postmaster holding unlinked files for pg_largeobject table
Previous Message Robert Haas 2011-06-09 18:59:57 Re: Invalid byte sequence for encoding "UTF8", caused due to non wide-char-aware downcase_truncate_identifier() function on WINDOWS