Re: pg_index updates and SI invalidation

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "Pavan Deolasee" <pavan(dot)deolasee(at)gmail(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pg_index updates and SI invalidation
Date: 2007-03-28 01:24:33
Message-ID: 12696.1175045073@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

"Pavan Deolasee" <pavan(dot)deolasee(at)gmail(dot)com> writes:
> Here is a patch which fixes this. We re-read part of the pg_index
> row and update rd_index with the new data. I tested REINDEX and CIC
> and both seems to work fine with the patch applied.

> Tom, does this look good ?

It seems a bit brute-force. Why didn't you use SearchSysCache(INDEXRELID)
the same as RelationInitIndexAccessInfo does? And what's the point of
the extra tuple copy step, instead of assigning the values into the
cache entry immediately?

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2007-03-28 01:34:46 Re: Warning on contrib/tsearch2
Previous Message Bruce Momjian 2007-03-28 01:15:25 Patch queue concern