Re: Errands around AllocateDir()

Michael Paquier <michael(dot)paquier(at)gmail(dot)com> writes:
> I had a close look at all the callers of AllocateDir() and noticed a
> couple of unwelcome things (Tom noticed some of those in the thread
> mentioned above, I found others):

Pushed with some minor additional fiddling. The most notable thing
I changed was that instead of this:

> - perform_base_backup() makes the mistake of not saving errno before
> CheckXLogRemoved() when AllocateDir returns NULL, which can lead to an
> incorrect error message.

I modified CheckXLogRemoved() to internally guarantee that it does not
change errno. This is because there seemed to be other call sites that
were depending on that, not just this one. Anyway, that seemed like a
more future-proof fix than relying on callers to deal with it.

regards, tom lane