Re: [COMMITTERS] pgsql: Move documentation of all recovery.conf option to a new chapter.

From: Simon Riggs <simon(at)2ndQuadrant(dot)com>
To: Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: [COMMITTERS] pgsql: Move documentation of all recovery.conf option to a new chapter.
Date: 2010-02-24 07:31:25
Message-ID: 1266996685.3752.5825.camel@ebony
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Wed, 2010-02-24 at 08:30 +0200, Heikki Linnakangas wrote:
> Simon Riggs wrote:
> > On Mon, 2010-02-22 at 11:47 +0000, Heikki Linnakangas wrote:
> >> Log Message:
> >> -----------
> >> Move documentation of all recovery.conf option to a new chapter.
> >> They used to be scattered between the "backup and restore" and "streaming
> >> replication" chapters.
> >
> > It's just taken me 15 minutes to locate the settings for
> > primary_conninfo to better understand Stefan's recent post.
> >
> > The commit referred to here is an extremely bad change.
> >
> > If you intended this to be a heading within the "High Availability"
> > chapter then I would agree. This is what I thought you had done.
>
> The idea was to have one chapter that describes all the options in
> recovery.conf. Some of them are specific to streaming replication
> (primary_conninfo), some are specific to PITR (recovery_target_*), some
> are common (restore_command, restore_end_command). We need a reference
> page to list them all.

We need a section, not a new chapter, if at all. A chapter on its own
for this makes no sense at all. The new section should either be in the
Backup, HA or Server Config chapters.

Please revert the change to create a new chapter.

--
Simon Riggs www.2ndQuadrant.com

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Robert Haas 2010-02-24 08:11:26 Re: Re: [COMMITTERS] pgsql: Move documentation of all recovery.conf option to a new chapter.
Previous Message Magnus Hagander 2010-02-24 07:11:34 Re: pgsql: Un-break pg_dump for the case of zero-column tables.

Browse pgsql-hackers by date

  From Date Subject
Next Message Simon Riggs 2010-02-24 07:46:31 Re: pg_stop_backup does not complete
Previous Message Magnus Hagander 2010-02-24 07:11:34 Re: pgsql: Un-break pg_dump for the case of zero-column tables.