| From: | Simon Riggs <simon(at)2ndQuadrant(dot)com> |
|---|---|
| To: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
| Cc: | Greg Smith <greg(at)2ndquadrant(dot)com>, Josh Berkus <josh(at)agliodbs(dot)com>, Selena Deckelmann <selenamarie(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Dividing progress/debug information in pg_standby, and stat before copy |
| Date: | 2010-01-26 09:36:01 |
| Message-ID: | 1264498561.24669.4506.camel@ebony |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, 2010-01-26 at 11:08 +0900, Fujii Masao wrote:
> On Tue, Jan 26, 2010 at 9:08 AM, Simon Riggs <simon(at)2ndquadrant(dot)com> wrote:
> > Just committed a fix: the server no longer requests 0000000001.history
> > at start of archive recovery.
>
> Good.
>
> And I think that writeTimeLineHistory() should also skip the request
> of 0000000001.history. Here is the patch to do so. Comments?
I didn't think it was worth the bother, since you can't easily avoid
requesting 00000002.history or whatever the newTLI will be, so you do
still get some messages that might appear spurious. Sure we could
rewrite that, but it works and we have other matters to attend.
Also, I'm not going to add a Goto to the Postgres source code. You've
spent too long staring at ReadRecord(), it seems. :-)
--
Simon Riggs www.2ndQuadrant.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Magnus Hagander | 2010-01-26 09:41:44 | Re: Dividing progress/debug information in pg_standby, and stat before copy |
| Previous Message | Michael Meskes | 2010-01-26 08:46:10 | Re: ECPG patch 4.1, out-of-scope cursor support in native mode |