From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Neil Conway <neilc(at)samurai(dot)com> |
Cc: | Pavel Stehule <stehule(at)kix(dot)fsv(dot)cvut(dot)cz>, pgsql-patches(at)postgresql(dot)org, pgman(at)candle(dot)pha(dot)pa(dot)us |
Subject: | Re: final light versions of Oracle compatibility (SQLSTATE, GREATEST, |
Date: | 2005-06-09 16:39:14 |
Message-ID: | 12643.1118335154@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-patches |
Neil Conway <neilc(at)samurai(dot)com> writes:
> Attached is a revised version of this patch. I'll apply it tonight or
> tomorrow, barring any objections.
I still find the grammar changes to be an ugly kluge --- it should be
possible to do this without introducing bogus nonterminals.
The ns push/pop operations don't appear to be correctly matched
(consider multiple WHEN clauses, a case the regression test does not
cover), nor do they surround the places where the variables are created.
It is likely that you don't need a push/pop at all; if it appears to
work now it's because the end of the block results in a pop and so
the variables disappear then anyway.
The patch is sloppy about whether free_var() is static or not.
I find the proposed change in plpgsql_ns_additem a distinct
disimprovement --- it's dubious even as a micro-optimization
and it certainly hurts legibility.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2005-06-09 17:20:37 | Re: final light versions of Oracle compatibility (SQLSTATE, |
Previous Message | Bruce Momjian | 2005-06-09 16:33:59 | Re: to_timestamp overloaded to convert from Unix epoch |