| From: | Simon Riggs <simon(at)2ndQuadrant(dot)com> | 
|---|---|
| To: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> | 
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> | 
| Subject: | Re: Streaming replication, and walsender during recovery | 
| Date: | 2010-01-19 07:41:10 | 
| Message-ID: | 1263886870.3642.6161.camel@ebony | 
| Views: | Whole Thread | Raw Message | Download mbox | Resend email | 
| Thread: | |
| Lists: | pgsql-hackers | 
On Tue, 2010-01-19 at 15:04 +0900, Fujii Masao wrote:
> >
> > There is an ERROR, but no problem AFAICS. The tli isn't set until end of
> > recovery because it doesn't need to have been set yet. That shouldn't
> > prevent retrieving WAL data.
> 
> OK. Here is the patch which supports a walsender process during recovery;
> 
> * Change walsender so as to send the WAL written by the walreceiver
>   if it has been started during recovery.
> * Kill the walsenders started during recovery at the end of recovery
>   because replication cannot survive the change of timeline ID.
Good patch.
I think we need to add a longer comment explaining the tli issues. I
agree with your handling of them.
It would be useful to have the ps display differentiate between multiple
walsenders, and in this case have it indicate cascading also.
-- 
 Simon Riggs           www.2ndQuadrant.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2010-01-19 07:48:03 | Re: Patch: Remove gcc dependency in definition of inline functions | 
| Previous Message | Jeff Davis | 2010-01-19 07:08:45 | Re: Listen / Notify - what to do when the queue is full |