Re: Quoting of psql \d output

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, chriskl(at)familyhealth(dot)com(dot)au, pgsql-patches(at)postgresql(dot)org
Subject: Re: Quoting of psql \d output
Date: 2003-12-27 18:13:55
Message-ID: 12610.1072548835@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> So it seems we can either go with no quotes, or smart quotes (which my
> patch implemented). I feel my patch does the best of both worlds, by
> quoting as needed, and as the psql \d commands actually require anyway,
> and as used by pg_dump and in SQL queries.

You have not responded to Peter's point that quotes need translation.

If we adopt the viewpoint that this is an SQL representation of the
table name, and not a human-oriented one, then double quotes are correct
regardless of the language in use. However, we agreed during
development of the message style guidelines that we would *not* use
strict SQL quoting in messages. I have not seen a good reason given
to ignore that general policy in this particular case.

I think if we change it here we will also have to revisit hundreds of
places in the backend, such as this one:
regression=# select * from public.bar;
ERROR: relation "public.bar" does not exist
and indeed the whole question of what we are using quotes for in
messages becomes open again.

At this point I think I'm voting with Peter, for no change at all.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2003-12-27 18:26:28 Re: Quoting of psql \d output
Previous Message Randal L. Schwartz 2003-12-27 17:51:32 Re: Is my MySQL Gaining ?

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2003-12-27 18:26:28 Re: Quoting of psql \d output
Previous Message ohp 2003-12-27 16:56:03 Re: [PATCHES] update i386 spinlock for hyperthreading