Re: enable-thread-safety defaults?

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Magnus Hagander <magnus(at)hagander(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: enable-thread-safety defaults?
Date: 2009-12-10 22:58:19
Message-ID: 1260485899.716.12.camel@vanquo.pezone.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On tis, 2009-12-01 at 18:03 -0500, Bruce Momjian wrote:
> Tom Lane wrote:
> > Magnus Hagander <magnus(at)hagander(dot)net> writes:
> > > 2009/12/1 Bruce Momjian <bruce(at)momjian(dot)us>:
> > >> What are we going to do for build farm members who don't support
> > >> threading? Is someone going to manually update their configure flags?
> >
> > > Yeah, I think so.
> >
> > > Unless there's a whole lot of them, in which case we revert the patch.
> >
> > It would seem like we ought to try the one-liner patch Magnus proposed
> > (ie flip the default) and see what the effects are, before we go with
> > the much larger patch Bruce wrote.
>
> OK, done --- let the breakage begin. (I will be monitoring the build
> farm and will work with Andrew Dunstan on any issues.)

You have removed all the configure code that defined
ENABLE_THREAD_SAFETY, but there is still lots and lots of code that
checks for #ifdef ENABLE_THREAD_SAFETY. So this is is probably quite
broken at the moment.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2009-12-10 22:59:01 Re: thread safety on clients
Previous Message Greg Smith 2009-12-10 22:49:11 CommitFest 2009-11: Reviews complete