From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Alexander Lakhin <exclusion(at)gmail(dot)com> |
Cc: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, pgsql-bugs(at)lists(dot)postgresql(dot)org |
Subject: | Re: BUG #16161: pg_ctl stop fails sometimes (on Windows) |
Date: | 2019-12-19 20:09:45 |
Message-ID: | 12599.1576786185@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-bugs |
Alexander Lakhin <exclusion(at)gmail(dot)com> writes:
> Maybe we should change the condition to 'if (stat(fileName, &st) != 0 &&
> (err = GetLastError()) == ERROR_ACCESS_DENIED)' to avoid unnecessary
> sleep with a loop iteration...
Well, we have to loop back on file-not-found too ...
> It seems that the check for ERROR_DELETE_PENDING was added to
> pgwin32_safestat() blindly, the issue wasn't reproduced at that time:
> https://www.postgresql.org/message-id/CAB7nPqRJV6trFta-Qzgi6j2feuYR2ZC%2BKHvWdHnbpDG2scTrxw%40mail.gmail.com
Hmm, makes one wonder whether that's actually live code.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Juan José Santamaría Flecha | 2019-12-19 20:49:54 | Re: BUG #16161: pg_ctl stop fails sometimes (on Windows) |
Previous Message | Alexander Lakhin | 2019-12-19 20:00:00 | Re: BUG #16161: pg_ctl stop fails sometimes (on Windows) |