Re: [PATCH] Add solaris path for docbook COLLATEINDEX

From: Zdenek Kotala <Zdenek(dot)Kotala(at)Sun(dot)COM>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Peter Eisentraut <peter_e(at)gmx(dot)net>
Subject: Re: [PATCH] Add solaris path for docbook COLLATEINDEX
Date: 2009-11-30 18:53:18
Message-ID: 1259607198.1115.109.camel@localhost
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Bruce Momjian píše v po 30. 11. 2009 v 12:32 -0500:
> Zdenek Kotala wrote:
> > collateindex.pl is stored in /usr/share/sgml/docbook/. Attached fix
> > modify docbook.m4 to find correct path.
> >
> > It would be nice also backported the fix back at least to 8.2.
>
> I am not happy looking in a directory _above_ a specified directory by
> default:
>
> [$DOCBOOKSTYLE/bin $DOCBOOKSTYLE/.. $PATH])
>
> That seems possibly unsafe. I suggest you just add it to the PATH for
> Solaris builds.

I'm not sure if it is unsafer that searching in $PATH. Anyway I don't
think that your proposed solution is good way. I'm able to do it but how
many other people can? Who know where collateindex.pl stays on Solaris?
configure is here to make live easier for people. If we know how to do
it automatically we should do it.

If you think that $DOCBOOKSTYLE/.. is not good than I propose to
use /usr/share/sgml/docbook/ directly.

Zdenek

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2009-11-30 18:56:40 Re: Writeable CTE patch
Previous Message Tom Lane 2009-11-30 18:48:10 Re: Deleted WAL files held open by backends in Linux