| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
| Cc: | Hubert Fröhlich <hubert(dot)froehlich(at)bvv(dot)bayern(dot)de>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: [GENERAL] WARNING: could not remove database directory |
| Date: | 2005-02-11 18:48:35 |
| Message-ID: | 12583.1108147715@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-general pgsql-hackers |
Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> Tom Lane wrote:
>> It's certainly not realistic to pass back enough information from
>> rmtree() to let the caller print a useful error message, so I think
>> we have to add reporting code along this line to rmtree().
> Agreed. Not sure how the rmtree stuff was removed. I will look into
> re-adding it, I assume for 8.1 only not 8.0.X?
I'd put it into 8.0 as well. The only reason not to is that the strings
won't be translated (unless the translators add them later) ... but an
untranslated message is still tons better than no message at all.
Speaking of untranslated, the fprintf(stderr) calls in the other
routines are missing the gettext() invocations they need to have to be
translatable, so they have problems already.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ignacio Colmenero | 2005-02-11 18:51:14 | ERROR: control reached end of function without RETURN |
| Previous Message | Tom Lane | 2005-02-11 18:43:34 | Re: size in bytes of a table? |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Fuhr | 2005-02-12 06:06:34 | 8.x VACUUM overestimates reltuples? |
| Previous Message | Bruce Momjian | 2005-02-11 18:43:31 | Re: [GENERAL] WARNING: could not remove database directory |