[Patch] Fix enum type mismatch

From: Zdenek Kotala <Zdenek(dot)Kotala(at)Sun(dot)COM>
To: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: [Patch] Fix enum type mismatch
Date: 2009-11-13 15:29:00
Message-ID: 1258126140.1316.7.camel@localhost
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Attached patch fixed following warning:

"../../../src/include/nodes/parsenodes.h", line 487: warning: enumerator
value overflows INT_MAX (2147483647)

The reason is clear, enum is int not unsigned.

It is short fix, but I'm thinking about enum conversion to #define. We
use e.g. in the same file.

60 typedef uint32 AclMode; /* a bitmask of privilege bits */
61
62 #define ACL_INSERT (1<<0) /* for relations */
63 #define ACL_SELECT (1<<1)
64 #define ACL_UPDATE (1<<2)
65 #define ACL_DELETE (1<<3)
66 #define ACL_TRUNCATE (1<<4)
67 #define ACL_REFERENCES (1<<5)
68 #define ACL_TRIGGER (1<<6)

Zdenek

Attachment Content-Type Size
parsenode.patch text/x-patch 454 bytes

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2009-11-13 15:35:08 Re: Aggregate ORDER BY patch
Previous Message Aidan Van Dyk 2009-11-13 15:14:02 Re: next CommitFest