Re: pgsql: Avoid tricky race condition recording XLOG_HINT

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Simon Riggs <simon(at)2ndQuadrant(dot)com>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Avoid tricky race condition recording XLOG_HINT
Date: 2013-04-08 14:29:20
Message-ID: 12578.1365431360@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Simon Riggs <simon(at)2ndQuadrant(dot)com> writes:
> Resulting code completely changes layout of XLOG_HINT WAL records, but
> this isn't even beta code, so this is a low impact change.

> src/include/catalog/catversion.h | 2 +-

Just for the record, the right way to handle that kind of change is to
change XLOG_PAGE_MAGIC, not catversion. A database's catalog version
might not be available to code that is inspecting WAL files and would
like to know what format it should expect.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2013-04-08 14:36:26 Re: [COMMITTERS] pgsql: Get rid of USE_WIDE_UPPER_LOWER dependency in trigram constructi
Previous Message Heikki Linnakangas 2013-04-08 13:30:22 pgsql: Fix calculation of how many segments to retain for wal_keep_segm