Re: Remove unnecessary static specifier

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Japin Li <japinli(at)hotmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Remove unnecessary static specifier
Date: 2025-02-05 12:52:53
Message-ID: 12572EF5-3CE2-4D75-9441-F73BEA38EF45@yesql.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 5 Feb 2025, at 13:30, Japin Li <japinli(at)hotmail(dot)com> wrote:

> When reviewing patch [1], I find that the static class specifier is unnecessary
> for the variables sp and ep in the function px_crypt_md5().

From a quick first inspection (and running the tests with the patch applied) I
agree with this, these variables do not need to be static. I'll stare a bit
more at this to make sure but seems like the right patch.

--
Daniel Gustafsson

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message John Naylor 2025-02-05 13:34:59 Sort functions with specialized comparators
Previous Message Ryo Kanbayashi 2025-02-05 12:31:28 [PATCH] Add regression tests of ecpg command notice (error / warning)