Re: reallocing without oom check in pg_regress

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Daniel Gustafsson <daniel(at)yesql(dot)se>
Cc: PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: reallocing without oom check in pg_regress
Date: 2022-02-23 22:05:15
Message-ID: 1257248.1645653915@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Daniel Gustafsson <daniel(at)yesql(dot)se> writes:
> In pg_regress we realloc() with the destination and source pointer being equal,
> without checking for OOM. While a fairly unlikely source of errors, is there a
> reason not to use pg_realloc() there for hygiene?

Yeah, looks like oversight to me.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Euler Taveira 2022-02-23 22:05:58 Re: logical decoding and replication of sequences
Previous Message Tom Lane 2022-02-23 22:03:56 Re: convert libpq uri-regress tests to tap test