Re: Fix a wrong comment in load_file()

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: cca5507 <cca5507(at)qq(dot)com>, pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Fix a wrong comment in load_file()
Date: 2024-12-23 04:15:31
Message-ID: 1255427.1734927331@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Michael Paquier <michael(at)paquier(dot)xyz> writes:
> While on it, I think that we should adjust all these ones too:
> contrib/sepgsql/hooks.c: * Module load/unload callback
> contrib/auto_explain/auto_explain.c:/* Saved hook values in case of
> unload */
> contrib/passwordcheck/passwordcheck.c:/* Saved hook value in case of
> unload */
> contrib/pg_stat_statements/pg_stat_statements.c:/* Saved hook values
> in case of unload */

Check.

> The saved hooks are not here to readjust the stack based on a reload,
> just to make sure that the existing paths loaded are all taken. I
> would just remove the "in case of unload" part for the last three, and
> "unload" for the first one. Thoughts?

WFM

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message 2024-12-23 04:16:37 transaction lost when delete clog file after normal shutdown
Previous Message Michael Paquier 2024-12-23 04:10:34 Re: Fix a wrong comment in load_file()