| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Dead encoding conversion functions |
| Date: | 2019-06-30 21:30:09 |
| Message-ID: | 12546.1561930209@sss.pgh.pa.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> writes:
> On 2019-05-29 21:03, Tom Lane wrote:
>> If we do delete them as useless, it might also be advisable to change
>> CreateConversionCommand() to refuse creation of conversions to/from
>> SQL_ASCII, to prevent future confusion.
> It seems nonsensical by definition to allow that.
Here's a completed patch for that. Obviously this is a bit late
for v12, but if there aren't objections I'll push this soon after
v13 opens.
regards, tom lane
| Attachment | Content-Type | Size |
|---|---|---|
| remove-dead-encoding-conversions-1.patch | text/x-diff | 22.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Gierth | 2019-06-30 23:00:33 | Re: Fix up grouping sets reorder |
| Previous Message | Tomas Vondra | 2019-06-30 18:26:40 | Re: [PATCH] Implement uuid_version() |