From: | Simon Riggs <simon(at)2ndQuadrant(dot)com> |
---|---|
To: | Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> |
Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Hot Standby on git |
Date: | 2009-10-02 10:46:51 |
Message-ID: | 1254480411.17864.368.camel@ebony.2ndQuadrant |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Fri, 2009-10-02 at 11:26 +0300, Heikki Linnakangas wrote:
> Simon Riggs wrote:
> > On Fri, 2009-10-02 at 10:43 +0300, Heikki Linnakangas wrote:
> >
> >> It seems dangerous to write a WAL record after the shutdown checkpoint.
> >> It will be overwritten by subsequent startup, which is a recipe for trouble.
> >
> > I've said its a corner case and not worth spending time on. I'm putting
> > it in at your request. If it's not correct before and not correct after,
> > where exactly do you want it?
>
> I don't know. Perhaps it should go between the REDO pointer of the
> shutdown checkpoint and the checkpoint record itself. Or maybe the
> information should be included in the checkpoint record itself.
I've implemented this but it requires us to remove two checks - one at
shutdown and one at startup on a shutdown checkpoint. I'm not happy
doing that and would like to put them back.
I'd rather just skip this for now. It's a minor case anyway and there's
nothing stopping writing their own RunningXactData records with a
function, if it is needed. I can add a function for that.
--
Simon Riggs www.2ndQuadrant.com
From | Date | Subject | |
---|---|---|---|
Next Message | Heikki Linnakangas | 2009-10-02 10:52:33 | Re: Hot Standby on git |
Previous Message | Marko Tiikkaja | 2009-10-02 10:32:47 | Re: Using results from INSERT ... RETURNING |