| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | cca5507 <cca5507(at)qq(dot)com>, pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Fix a wrong comment in load_file() |
| Date: | 2024-12-23 03:50:47 |
| Message-ID: | 1252412.1734925847@sss.pgh.pa.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Michael Paquier <michael(at)paquier(dot)xyz> writes:
> On Mon, Dec 23, 2024 at 10:58:49AM +0800, cca5507 wrote:
> * This function loads a shlib file without looking up any particular
> * function in it. If the same shlib has previously been loaded,
> - * unload and reload it.
> + * we don't load it again.
> Right. This comment is misleading.
I think it was once correct, decades ago. Obviously we missed
fixing it when we ripped out the unload functionality.
> - /* Load the shared library */
> + /* Load the shared library, unless we already did */
> This comment is still true, though.
Seems like an improvement to me?
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | mahendrakar s | 2024-12-23 03:52:06 | Last removed wal segment file |
| Previous Message | Michael Paquier | 2024-12-23 03:42:25 | Re: Fix a wrong comment in load_file() |