Re: clang's static checker report.

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: Greg Stark <gsstark(at)mit(dot)edu>
Cc: Grzegorz Jaskiewicz <gj(at)pointblue(dot)com(dot)pl>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alex Hunsaker <badalex(at)gmail(dot)com>, pgsql-hackers Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: clang's static checker report.
Date: 2009-08-30 14:26:39
Message-ID: 1251642399.22097.0.camel@vanquo.pezone.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On lör, 2009-08-29 at 17:35 +0100, Greg Stark wrote:
> We still have things like this showing "division by zero":
>
> Assert(activeTapes > 0);
> 1913 slotsPerTape = (state->memtupsize - state->mergefirstfree) / activeTapes;
>
>
> It looks like if you marked ExceptionalCondition() as never returning
> then it should hide this.

Well, if you can disable the assertion, then there is still a possible
bug here, no?

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Greg Stark 2009-08-30 14:40:16 Re: clang's static checker report.
Previous Message Grzegorz Jaskiewicz 2009-08-30 13:26:32 Re: clang's static checker report.