Re: BUG #4879: bgwriter fails to fsync the file in recovery mode

From: Simon Riggs <simon(at)2ndQuadrant(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, pgsql-bugs(at)postgresql(dot)org
Subject: Re: BUG #4879: bgwriter fails to fsync the file in recovery mode
Date: 2009-06-30 08:26:15
Message-ID: 1246350375.27964.43.camel@dn-x300-willij
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs


On Fri, 2009-06-26 at 16:48 -0400, Tom Lane wrote:

> * I find the RecoveryInProgress test in XLogNeedsFlush rather dubious.
> Why is it okay to disable that? For at least one of the two callers
> (SetHintBits) it seems like the safe answer is "true" not "false".
> This doesn't matter too much yet but it will for hot standby.

IIUC you think it is safest to *not* write hint bits during Hot Standby?

So we would treat all commits as async commits?

--
Simon Riggs www.2ndQuadrant.com
PostgreSQL Training, Services and Support

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Alvaro Herrera 2009-06-30 14:29:27 Re: BUG #4895: OneClickInstaller dont appreciates Client_Encoding and also listen_addresses='*'
Previous Message Uwe Liebehenz 2009-06-30 07:20:11 BUG #4895: OneClickInstaller dont appreciates Client_Encoding and also listen_addresses='*'