| From: | Simon Riggs <simon(at)2ndQuadrant(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: that picksplit debug message again |
| Date: | 2009-06-25 09:36:06 |
| Message-ID: | 1245922566.4038.62.camel@ebony.2ndQuadrant |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, 2009-06-24 at 01:19 -0400, Tom Lane wrote:
> Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
> > Is the %d actually in the right place here?
> > errmsg("picksplit method for %d column of index \"%s\" failed",
> > attno + 1, RelationGetRelationName(r))
>
> No, any native speaker of English would say "for column %d". Putting
> "failed" at the end seems a bit awkward as well, though I can't offhand
> see a better phrasing. "picksplit method failed for ..." is *not*
> better; it implies there is only one picksplit method for everything,
> whereas the point of the message is that the one associated with this
> column failed.
"has failed"?
--
Simon Riggs www.2ndQuadrant.com
PostgreSQL Training, Services and Support
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dimitri Fontaine | 2009-06-25 09:38:22 | Re: Extensions User Design |
| Previous Message | Magnus Hagander | 2009-06-25 09:32:44 | Re: Extensions User Design |