From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | "Guillaume Smet" <guillaume(dot)smet(at)gmail(dot)com> |
Cc: | pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: Inconsistency in extended-query-protocol logging |
Date: | 2006-09-13 15:52:05 |
Message-ID: | 12459.1158162725@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
"Guillaume Smet" <guillaume(dot)smet(at)gmail(dot)com> writes:
> IMHO, it's more logical to remove it as the text after statement: is
> not a statement in the extended query protocol case.
Well, I was never particularly enamored of the idea that we should put
statement: into everything generated by log_statement. My proposal
would be to generate
statement: querystring Simple Query
parse <stmt>: querystring Parse
bind <stmt>/<portal>: querystring Bind
execute <stmt>/<portal>: querystring Execute
or these prefixed with "duration: xxx", as appropriate. Bruce was
pretty hot about having statement: in there, so the hard part might
be to convince him.
Also, the current code distinguishes a "fetch" from an
already-partially-executed portal ... do you care about that?
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Guillaume Smet | 2006-09-13 16:06:16 | Re: Inconsistency in extended-query-protocol logging |
Previous Message | Albe Laurenz | 2006-09-13 15:51:12 | Re: [PATCHES] Linking on AIX (Was: Fix linking of OpenLDAP libraries ) |