Re: pgsql/src/interfaces/libpq (fe-connect.c)

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Alfred Perlstein <bright(at)wintelcom(dot)net>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql/src/interfaces/libpq (fe-connect.c)
Date: 2000-12-18 19:07:20
Message-ID: 1243.977166440@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Alfred Perlstein <bright(at)wintelcom(dot)net> writes:
>> Ensure that 'errno' is saved and restored by all signal handlers that
>> might change it.

> I'm not sure why you're doing this, if someone calls PQrequestCancel,
> they shouldn't expect it to preserve errno.

PQrequestCancel is designed and documented to be callable from user
signal handlers, so it seems like good defensive programming to make
it save/restore errno.

regards, tom lane

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message tgl 2000-12-18 23:39:37 pgsql/doc/src/sgml (advanced.sgml array.sgml syntax.sgml)
Previous Message momjian 2000-12-18 18:45:06 pgsql/src/include/port (beos.h)