Re: citex regression fails with de.UTF8 locale

From: Zdenek Kotala <Zdenek(dot)Kotala(at)Sun(dot)COM>
To: Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>
Cc: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: citex regression fails with de.UTF8 locale
Date: 2009-04-23 08:13:04
Message-ID: 1240474384.1275.9.camel@localhost
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


Heikki Linnakangas píše v čt 23. 04. 2009 v 10:22 +0300:
> Zdenek Kotala wrote:

> Comment and test case fixed.

Thanks

> I considered changing varstr_cmp to really
> return -1, 0 or 1, but I didn't because the behavior has been unchanged
> for ages and all the callers are happy with it. That's a heavily called
> function so any extra cycles there could make a difference.

I think keep it as it is good decision. strcmp() also does not guarantee
-1, 0, 1.

Zdenek

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Jasen Betts 2009-04-23 10:38:21 Re: Workaround for bug #4608?
Previous Message Heikki Linnakangas 2009-04-23 07:49:13 Re: New trigger option of pg_standby