| From: | Simon Riggs <simon(at)2ndQuadrant(dot)com> |
|---|---|
| To: | Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> |
| Cc: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, Guillaume Smet <guillaume(dot)smet(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Peter Eisentraut <peter_e(at)gmx(dot)net>, Kevin Grittner <Kevin(dot)Grittner(at)wicourts(dot)gov>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: New trigger option of pg_standby |
| Date: | 2009-04-21 11:03:56 |
| Message-ID: | 1240311836.23905.206.camel@ebony.fara.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, 2009-04-20 at 17:47 +0300, Heikki Linnakangas wrote:
> At the end of archive recovery, the server always probes for the
> timeline by requesting history files until it fails to find one. That
> probing should remove the trigger file if it hasn't been removed by
> then. It's a bit coincidental to rely on that, but at least it's simple.
> The assumption we're making is that the server won't exit recovery
> before asking restore_command for a file that doesn't exist.
If you really want to simplify this, then we should have a final_command
parameter for a command to be executed at the end of recovery. That
would make the change to pg_standby very simple and allow for a very
simple final_command also. That would make the logic similar to what we
do for aggregates: transition function and final function.
We could call it restore_cleanup_command or something similar.
I suspect this option will make you consider Fujii-san's patch in a
better light. :-)
--
Simon Riggs www.2ndQuadrant.com
PostgreSQL Training, Services and Support
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Heikki Linnakangas | 2009-04-21 11:17:47 | Re: New trigger option of pg_standby |
| Previous Message | Abhijit Menon-Sen | 2009-04-21 10:46:04 | Re: [PATCH] Add a test for pg_get_functiondef() |