Re: postgresql.conf: patch to have ParseConfigFile report all parsing errors, then bail

On Tue, 2009-03-10 at 07:30 -0700, Selena Deckelmann wrote:

> > Is it possible to check for parameters that have been changed, yet will
> > not be applied at reload?
>
> This was already implemented! :) For example:
>
> LOG: attempted change of parameter "shared_buffers" ignored
> DETAIL: This parameter cannot be changed after server start.
> LOG: attempted change of parameter "max_prepared_transactions" ignored
> DETAIL: This parameter cannot be changed after server start.

OK, had that at the back of my mind for a while I guess.

> A thing that could be added, however, is reporting of all invalid (as
> opposed to valid, but requires a restart to apply) parameters before
> exiting. This change requires refactoring ProcessConfigFile() more
> significantly, as the parsing and validity checks are done separately,
> and are exited with gotos. :)
>
> I haven't tried to change this yet, but was planning to.

Can't we just do a reload, but with doit = false?

--
Simon Riggs www.2ndQuadrant.com
PostgreSQL Training, Services and Support