Re: [PATCH] Regression test fix for Czech locale

From: Zdenek Kotala <Zdenek(dot)Kotala(at)Sun(dot)COM>
To: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
Cc: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Peter Eisentraut <peter_e(at)gmx(dot)net>
Subject: Re: [PATCH] Regression test fix for Czech locale
Date: 2009-03-06 15:28:30
Message-ID: 1236353310.1404.95.camel@localhost
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


Alvaro Herrera píše v pá 06. 03. 2009 v 12:16 -0300:
> Zdenek Kotala wrote:
> > I attached fix which modify foreign_data test. It fix problem with Czech
> > collation when numbers are ordered after letters. I retyped affected
> > column to name datatype which uses bitwise cmp.
>
> I have trouble understanding why this makes any sense at all. The only
> thing you seem to be doing here is replacing the ORDER BY column-number
> clauses by others that reference the column by name.

And I cast foreign_server_name to name datatype (which is original
datatype in catalog table). See my buildfarm member:

http://www.pgbuildfarm.org/cgi-bin/show_log.pl?nm=gothic_moth&dt=2009-03-04%2021:06:01

for details.

> Isn't this a bug in how column numbers are (not) being used by ORDER BY?

you cannot use 3::name. It is reason why I replaced numbers with names
and I did it for all select here. It has seemed that is better idea do
it everywhere and be consistent.

Zdenek

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2009-03-06 17:01:36 small parallel restore optimization
Previous Message Tom Lane 2009-03-06 15:27:52 Re: Validating problem in the isn contrib module