From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | David Fetter <david(at)fetter(dot)org> |
Cc: | PG Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Macros for typtype (was Re: Arrays of Complex Types) |
Date: | 2007-03-31 23:10:08 |
Message-ID: | 12358.1175382608@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-patches |
I wrote:
> David Fetter <david(at)fetter(dot)org> writes:
>> What parts of the code would need a once-over?
> A lot :-( ... probably every place that touches typtype or typelem would
> need at least a look. It'd be a good idea to take the opportunity to
> start using macros for the values of typtype, as we do for relkind but
> for some reason never adopted for typtype.
I just realized that I need to check every usage of typtype to be sure
that the enums patch is sane. So, barring objection, I intend to take
this opportunity to make the code stop referring directly to 'b', 'c'
etc whereever possible. Any objections to these names?
#define TYPTYPE_BASE 'b'
#define TYPTYPE_COMPOSITE 'c'
#define TYPTYPE_DOMAIN 'd'
#define TYPTYPE_ENUM 'e'
#define TYPTYPE_PSEUDO 'p'
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Andrew Dunstan | 2007-03-31 23:12:25 | Re: Last minute mini-proposal (I know, I know)forPQexecf() |
Previous Message | Peter Eisentraut | 2007-03-31 22:36:01 | Re: Autovacuum vs statement_timeout |
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2007-03-31 23:13:20 | Re: Macros for typtype (was Re: Arrays of Complex Types) |
Previous Message | Bruce Momjian | 2007-03-31 23:01:03 | Re: COPY-able sql log outputs |