Re: Hot Standby: subxid cache changes

From: Simon Riggs <simon(at)2ndQuadrant(dot)com>
To: Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Hot Standby: subxid cache changes
Date: 2009-02-13 10:59:37
Message-ID: 1234522777.4500.1091.camel@ebony.2ndQuadrant
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


On Thu, 2009-02-12 at 09:50 +0200, Heikki Linnakangas wrote:

> It occurs to me that we don't need this patch for hot standby if we
> abuse the main xid array (SnapshotData.xip) to store the unobserved xids
> instead of the subxid array. That one is always scanned in
> XidInMVCCSnapshot. I think we should do that rather than try to salvage
> this patch.

I think my proposal still holds water, but I also think it is probably
time to say OK, let's make this simpler and take the subxid tuning off
line.

We would need to increase the max size of the xip array by
2*max_connections. So an increase of 80kB on normal running, which I can
accept.

Is that the only change you are suggesting to resolve this? I hope so.

--
Simon Riggs www.2ndQuadrant.com
PostgreSQL Training, Services and Support

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Heikki Linnakangas 2009-02-13 11:07:32 Re: Hot Standby: subxid cache changes
Previous Message Simon Riggs 2009-02-13 10:53:21 Re: Hot Standby: subxid cache changes