Re: Hot standby, RestoreBkpBlocks and cleanup locks

From: Simon Riggs <simon(at)2ndQuadrant(dot)com>
To: Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Hot standby, RestoreBkpBlocks and cleanup locks
Date: 2009-01-15 16:34:16
Message-ID: 1232037256.31921.57.camel@ebony.2ndQuadrant
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


On Thu, 2009-01-15 at 18:05 +0200, Heikki Linnakangas wrote:
> Simon Riggs wrote:
> > The idea outlined before didn't deal with all call points for
> > RecordIsCleanupRecord(), so doesn't actually work.
>
> Are we talking about the same thing?

I guess not. Look at the other call points for that function, cos your
suggestion didn't include them AFAICS.

> If we put the control of locking to
> the hands of the redo-function, I don't see why it couldn't use a lock
> of the right strength. Surely the redo-function can be taught what lock
> it needs to take.

Yes, it can, but there were other uses.

--
Simon Riggs www.2ndQuadrant.com
PostgreSQL Training, Services and Support

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2009-01-15 16:39:17 Re: FWD: Re: Updated backslash consistency patch
Previous Message Bruce Momjian 2009-01-15 16:25:23 Re: FWD: Re: Updated backslash consistency patch