| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Alvaro Herrera <alvaro(dot)herrera(at)2ndquadrant(dot)com> |
| Cc: | Boris Kolpackov <boris(at)codesynthesis(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Add version macro to libpq-fe.h |
| Date: | 2021-06-18 17:44:33 |
| Message-ID: | 1231631.1624038273@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Alvaro Herrera <alvaro(dot)herrera(at)2ndquadrant(dot)com> writes:
> So I'm +1 on adding this "feature macro".
Concretely, how about the attached? (I also got rid of a recently-added
extra comma. While the compilers we use might not warn about that,
it seems unwise to assume that no user's compiler will.)
I guess one unresolved question is whether we want to mention these in
the SGML docs. I vote "no", because it'll raise the maintenance cost
noticeably. But I can see an argument on the other side.
regards, tom lane
| Attachment | Content-Type | Size |
|---|---|---|
| libpq-feature-test-macros-1.patch | text/x-diff | 901 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2021-06-18 18:03:41 | Re: Add version macro to libpq-fe.h |
| Previous Message | Alvaro Herrera | 2021-06-18 17:39:52 | Re: Pipeline mode and PQpipelineSync() |