| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: incorrect xlog.c coverage report |
| Date: | 2018-11-21 18:20:48 |
| Message-ID: | 12312.1542824448@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> writes:
> On 2018-Nov-21, Masahiko Sawada wrote:
>> I've looked into this issue and this happens on my environment (CentOS
>> 6.9 and gcob 4.4.7) as well. ISTM the cause would related to the
>> immediate shutdown mode we're using in test_recovery_standby.
Doh, of course.
> I think we should change all calls of ->teardown_node to ->stop(),
> except the one in the END block, and look for places which are currently
> relying too much on END (i.e. add more ->stop() calls where needed).
Hm. We probably don't want to have zero coverage of immediate stop mode,
though I agree we could cut it way back.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Adrien NAYRAT | 2018-11-21 18:24:18 | Re: ALTER INDEX ... ALTER COLUMN not present in dump |
| Previous Message | Andrew Dunstan | 2018-11-21 18:17:57 | Re: [RFC] Removing "magic" oids |