Re: Slow standby snapshot

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Michail Nikolaev <michail(dot)nikolaev(at)gmail(dot)com>
Cc: Simon Riggs <simon(dot)riggs(at)enterprisedb(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Andrey Borodin <x4mmm(at)yandex-team(dot)ru>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, Alexander Korotkov <aekorotkov(at)gmail(dot)com>, reshkekirill <reshkekirill(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Slow standby snapshot
Date: 2022-11-29 21:39:04
Message-ID: 1225350.1669757944@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Michail Nikolaev <michail(dot)nikolaev(at)gmail(dot)com> writes:
> The small thing I was thinking to add in KnownAssignedXidsCompress is
> the assertion like

> Assert(MyBackendType == B_STARTUP);

Mmm ... given where the call sites are, we have got lots more problems
than this if some non-startup process reaches them. I'm not sure this
is worth the trouble, but if it is, I'd put it in the callers.

>> I'd be willing to
>> make the memory barrier change anyway, because that seems like
>> a simple change that can't hurt.

> I'm going to create a separate commit fest entry for it, ok?

Right, since I closed this one already.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Jeff Davis 2022-11-29 21:41:50 Re: Collation version tracking for macOS
Previous Message Tom Lane 2022-11-29 21:34:30 Re: Removing another gen_node_support.pl special case