| From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
|---|---|
| To: | Tristen Raab <tristen(dot)raab(at)highgo(dot)ca>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Cc: | Gurjeet Singh <gurjeet(at)singh(dot)im> |
| Subject: | Re: Better help output for pgbench -I init_steps |
| Date: | 2023-09-26 21:29:23 |
| Message-ID: | 1223a409-8826-0bf1-1cc4-ddb79cefc0e8@eisentraut.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 22.09.23 22:01, Tristen Raab wrote:
> The following review has been posted through the commitfest application:
> make installcheck-world: not tested
> Implements feature: tested, passed
> Spec compliant: not tested
> Documentation: not tested
>
> Hello,
>
> I've reviewed all 4 of your patches, each one applies and builds correctly.
>
>> I think I prefer variant 2. Currently, we only have 8 steps, so it might
>> be overkill to separate them out into a different option.
>
> +1 to this from Peter. Variant 2 is nicely formatted with lots of information which I feel better solves the problem this patch is trying to address.
Committed variant 2. I just changed the initial capitalization of the
sentences to be more consistent with the surrounding text.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2023-09-26 21:42:13 | Re: [PATCH] pgrowlocks: Make mode names consistent with docs |
| Previous Message | Heikki Linnakangas | 2023-09-26 21:14:26 | Re: Is this a problem in GenericXLogFinish()? |