Re: [PATCHES] Infrastructure changes for recovery

From: Simon Riggs <simon(at)2ndQuadrant(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: List pgsql-patches <pgsql-patches(at)postgresql(dot)org>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCHES] Infrastructure changes for recovery
Date: 2008-10-02 22:11:28
Message-ID: 1222985488.4445.1625.camel@ebony.2ndQuadrant
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches


On Thu, 2008-09-25 at 18:28 -0400, Tom Lane wrote:
> Simon Riggs <simon(at)2ndQuadrant(dot)com> writes:
> > Version 7
>
> After reading this for awhile, I realized that there is a rather
> fundamental problem with it: it switches into "consistent recovery"
> mode as soon as it's read WAL beyond ControlFile->minRecoveryPoint.

Just seen this patch has been bounced into November CommitFest, even
though the new patch fixes all of the concerns raised.

I'm concerned that this is going to make the final Hot Standby patch
fairly large, which will make it even harder to review, test and
generally get accepted.

What's the best way to make this easier for you/others to review?

--
Simon Riggs www.2ndQuadrant.com
PostgreSQL Training, Services and Support

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Decibel! 2008-10-02 22:23:41 Re: Block-level CRC checks
Previous Message Dawid Kuroczko 2008-10-02 21:51:59 Re: Block-level CRC checks

Browse pgsql-patches by date

  From Date Subject
Next Message Andrew Dunstan 2008-10-02 23:07:55 Re: [PATCHES] Infrastructure changes for recovery
Previous Message Alvaro Herrera 2008-10-02 00:29:35 Re: still alive?